feat: support license caching#634
Merged
Benoît Cortier (CBenoit) merged 9 commits intomasterfrom Jan 18, 2025
Merged
Conversation
Coverage Report 🤖 ⚙️Past: New: Diff: -0.55% [this comment will be updated automatically] |
Contributor
|
👀 thanks for improving licensing support, one of the trickiest areas of RDP |
Member
Benoît Cortier (CBenoit)
left a comment
Benoît Cortier (CBenoit)
left a comment
There was a problem hiding this comment.
Many thanks for working on this!!
Benoît Cortier (CBenoit)
approved these changes
Jan 18, 2025
Marc-Andre Lureau (elmarco)
added a commit
to elmarco/IronRDP
that referenced
this pull request
Jan 28, 2025
This fixes commit dd221bf ("feat: support license caching (Devolutions#634)") and semver-checks is now happy: type ProcessorOutput is no longer UnwindSafe, in /tmp/.tmppi9kAf/IronRDP/crates/ironrdp-session/src/x224/mod.rs:15 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for license caching by storing the license obtained from SERVER_UPGRADE_LICENSE message and sending CLIENT_LICENSE_INFO if we have license requested by the server stored.